Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E deploy test: rewrite in go tests #814

Merged
merged 58 commits into from
Jan 20, 2021
Merged

E2E deploy test: rewrite in go tests #814

merged 58 commits into from
Jan 20, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Nov 5, 2020 •
edited
Loading

Description:

  • E2E deploy tests re-written in golang.
  • E2E deploy tests will be run by labeling PRs with actions/e2e-deploy.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Nov 5, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@rinx rinx force-pushed the ci/e2e-deploy/rewrite-in-go-tests branch 4 times, most recently from e1a57c6 to b604eeb Compare November 5, 2020 08:15
@rinx rinx force-pushed the ci/e2e-deploy/rewrite-in-go-tests branch 3 times, most recently from ccfe2f4 to 17c59fd Compare November 10, 2020 07:49
@rinx
Copy link
Contributor Author

rinx commented Nov 10, 2020

/label actions/e2e-deploy

@rinx
Copy link
Contributor Author

rinx commented Nov 10, 2020

/label actions/e2e-deploy

@rinx rinx force-pushed the ci/e2e-deploy/rewrite-in-go-tests branch from 69edd73 to a12de43 Compare November 10, 2020 09:53
@rinx
Copy link
Contributor Author

rinx commented Nov 10, 2020

📝 after #740 merged into master, this PR will be revised to use v1 APIs for E2E CRUD tests.

@rinx
Copy link
Contributor Author

rinx commented Nov 11, 2020

/label actions/e2e-deploy
fixed the internal/db/rdb/mysql codes just for workaround. it should be revised later.

@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #814 (8186a7f) into master (fc1421e) will increase coverage by 0.16%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   15.91%   16.08%   +0.16%     
==========================================
  Files         474      475       +1     
  Lines       23684    23754      +70     
==========================================
+ Hits         3770     3820      +50     
- Misses      19678    19693      +15     
- Partials      236      241       +5
Impacted Files Coverage Δ
internal/db/rdb/mysql/mysql.go 95.67% <81.81%> (-0.81%) ⬇️
internal/worker/queue.go 98.33% <0.00%> (-1.67%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
internal/net/net.go 73.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adeefb...8186a7f. Read the comment docs.

@rinx
🔧 Fix Helm values for E2E test
4d27f64 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
💚 Fix method call
99ff8a8 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🔧 Reduce number of data
32dee0c 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
💚 Fix to use v1 vald API
2e131a8 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🔧 Reduce number of Scylla cluster member
0897a1e 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🚸 Add a variable for scylla deploy task
30eb7ce 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🔧 Add minio deploy task
8bc0f29 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
♻️ Use kubectl wait instead for sh loop
95413fb 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:pencil2: Fix typo

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
➕ Add cli-runtime to go.mod.default / Remove duplicated client-go entry
78c8b61 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
♻️ use assoc list for checking pr-xxx image existences
6b64c4e 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
⬆️ Update go.sum
bfd71b6 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
💚 Fix build
4e1754a 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🔧 tuning: add sleep
7ac2e01 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🔧 Tuning number of requests
7c242a2 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the ci/e2e-deploy/rewrite-in-go-tests branch from 1efbe3e to 7c242a2 Compare January 20, 2021 01:09
@rinx
💚 Fix e2e tests code
31d9436 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
✅ Update e2e tests
8186a7f 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
Copy link
Contributor Author

rinx commented Jan 20, 2021 •
edited
Loading

Updated.
E2E tests for Vald with Scylla and Vald with MySQL & Redis are failing on StreamUpdate operations.
Maybe caused by machine spec...

@rinx rinx requested a review from kpango January 20, 2021 02:27
kpango
kpango approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 7a78959 into master Jan 20, 2021
@kpango kpango deleted the ci/e2e-deploy/rewrite-in-go-tests branch January 20, 2021 05:56
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
Merged
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kpango kpango kpango approved these changes

@kmrmt kmrmt Awaiting requested review from kmrmt

@vankichi vankichi Awaiting requested review from vankichi

@hlts2 hlts2 Awaiting requested review from hlts2

@kevindiu kevindiu Awaiting requested review from kevindiu

Assignees
No one assigned
Labels
actions/e2e-deploy actions/fossa area/helm area/internal area/makefile area/manager/backup area/meta priority/low size/XXL team/set SET team team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinx @vdaas-ci @kpango